-
-
Notifications
You must be signed in to change notification settings - Fork 4.6k
chore(docs): add an updated Podman/Quadlets community guide #20744
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(docs): add an updated Podman/Quadlets community guide #20744
Conversation
|
Have you tried contributing to tbelway's repo? I'm hesitant to get into changing out links every time someone thinks it needs improving ;) |
I've thought about it, but since our guides are structured very differently, I don’t think replacing most of someone else’s repository would be the right move. For example, tbelway uses a single page with all the Quadlet files listed, while I’ve structured mine as individual Because of these differences, I don’t think a pull request is the right way forward. Instead, as a compromise, we could rename tbelway’s entry in community-guides.tsx to something like "Podman/Quadlets Install (with separated Microservices)", and add a new entry for my guide: "Immich Podman Quadlet Base (with related wiki guides)" Update: |
|
Feel free to simply add a second guide entry for yours. |
…e other podman one
thanks, changes are ready for review |
|
📖 Documentation deployed to pr-20744.preview.immich.app |
…pp#20744) * chore(docs): update Podman/Quadlets instructions link to a more up to date repo * Update community-guides.tsx: additional guide instead of replacing the other podman one * fix community-guides.tsx: fixed podman handbook entry * chore: linting --------- Co-authored-by: Jason Rasmussen <[email protected]>
Description
While I am thankful to Tbelway for creating instructions, I did not find them to be the most up-to-date or clearly arranged. So I've written my own! ;)
old instructions: https://github.com/tbelway/immich-podman-quadlets/blob/main/docs/install/podman-quadlet.md
mine: https://github.com/linux-universe/immich-podman-quadlets/blob/main/README.md
How Has This Been Tested?
I've tested everything not in the README mentioned as not tested on my own homeserver. On the things I couldn't test because of missing hardware, I took inspiration on Tbelways repo.
Checklist:
src/services/uses repositories implementations for database calls, filesystem operations, etc.src/repositories/is pretty basic/simple and does not have any immich specific logic (that belongs insrc/services/)