fix(web): memory viewer arrow navigation #19400
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Which browser are you using? |
Collaborator
Author
|
I'm using Google Chrome, I can only reproduce this on Windows, Version 137.0.7151.120 (Stable) |
Contributor
|
Deploying preview environment to https://pr-19400.preview.internal.immich.cloud/ |
Collaborator
Author
|
Can someone reproduce this issue to validate the fix, or should I dig into it more? |
Collaborator
Author
|
I can still reproduce this on v1.136.0! |
jrasm91
reviewed
Sep 10, 2025
Member
jrasm91
left a comment
jrasm91
left a comment
There was a problem hiding this comment.
Can you leave these shortcuts there all the time and see if simply changing preventDefault: true for ArrowLeft and ArrowRight fixes the issue for you?
Collaborator
Author
|
@jrasm91 setting |
jrasm91
force-pushed
the
fix/memory-arrow-nav
branch
from
caaa09b to
cf798ff
Compare
jrasm91
approved these changes
Sep 10, 2025
4 tasks
jochbru
pushed a commit
to pixelunioneu/immich
that referenced
this pull request
Sep 16, 2025
* fix(web): memory viewer jumps down on arrow keys * fix pnpm lockfile --------- Co-authored-by: Jason Rasmussen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
On v1.135 an issue appeared in the memory viewer that would cause the page to jump to the end when navigating using the arrow keys. This fixes it.
Video demo:
immich.memories.bug.mp4