Skip to content

Conversation

@shenlong-tanwen
Copy link
Member

Description

  • The App Store uses asynchronous operation for storing / updating a value. However, the other parts of the app assumes the operation to be synchronous leading to subtle issues occurring due to the operations running in out of order. This PR addresses one such case where on random occasions, the grid group settings change is not updated in the store before the timeline is refreshed, resulting in the timeline buckets still being grouped by the old setting.

Possibly fixes #18798

How Has This Been Tested?

The issue is hard to almost impossible to reproduce on an emulator. I could reproduce this few times on a physical device, but it is not consistent enough to confirm the fix works

@alextran1502 alextran1502 merged commit 091a101 into main Jun 2, 2025
55 checks passed
@alextran1502 alextran1502 deleted the fix/mobile-group-settings branch June 2, 2025 01:53
savely-krasovsky pushed a commit to savely-krasovsky/immich that referenced this pull request Jun 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Android app doesn't respect Photo Grid Group-by without restarting

3 participants