Skip to content

Conversation

@dagstuan
Copy link
Contributor

@dagstuan dagstuan commented May 31, 2025

Description

  • Fix an issue where clicking the zoom-button after having zoomed in would not zoom completely out, but leave the image in the zoomed-in state. The new behavior properly zoomes the image completely out after clicking the zoom-button.
  • Revert to the default setting for wheelZoomRatio as the previous setting of 0.2 was borderline unusable on a trackpad. This could probably be moved to a user setting if needed.
  • Add a keyboard shortcut 'z' to toggle image zoom.

Old behavior:
https://github.com/user-attachments/assets/2d836875-bb05-4f70-bb50-6483d725b242

Fixed behavior:
https://github.com/user-attachments/assets/bdc04165-07aa-4a5c-a09a-bb22dd0c6e68

How Has This Been Tested?

Manually tested in Google Chrome

Checklist:

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation if applicable
  • I have no unrelated changes in the PR.
  • I have confirmed that any new dependencies are strictly necessary.
  • I have written tests for new code (if applicable)
  • I have followed naming conventions/patterns in the surrounding code
  • All code in src/services/ uses repositories implementations for database calls, filesystem operations, etc.
  • All code in src/repositories/ is pretty basic/simple and does not have any immich specific logic (that belongs in src/services/)

* Fix an issue where clicking the zoom-button after having zoomed in
would not zoom completely out, but leave the image in the zoomed-in
state. The new behavior properly zoomes the image completely out after
clicking the zoom-button.
* Revert to the default setting for `wheelZoomRatio` as the previous
setting of 0.2 was borderline unusable on a trackpad. This could
probably be moved to a user setting if needed.
* Add a keyboard shortcut 'z' to toggle image zoom.
@alextran1502 alextran1502 merged commit 5589616 into immich-app:main Jun 2, 2025
50 of 51 checks passed
@dagstuan dagstuan deleted the zoomBehavior branch June 2, 2025 05:04
savely-krasovsky pushed a commit to savely-krasovsky/immich that referenced this pull request Jun 8, 2025
* Fix an issue where clicking the zoom-button after having zoomed in
would not zoom completely out, but leave the image in the zoomed-in
state. The new behavior properly zoomes the image completely out after
clicking the zoom-button.
* Revert to the default setting for `wheelZoomRatio` as the previous
setting of 0.2 was borderline unusable on a trackpad. This could
probably be moved to a user setting if needed.
* Add a keyboard shortcut 'z' to toggle image zoom.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants