Skip to content

fix(mobile): t function localization #18768

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
alextran1502 merged 2 commits into from
Jun 3, 2025
Merged

fix(mobile): t function localization #18768

alextran1502 merged 2 commits into from
Jun 3, 2025

Conversation

@waclaw66
Copy link
Contributor

@waclaw66 waclaw66 commented May 30, 2025 •
edited
Loading

  • fixed t function to use current language (not always en as before)
    - uses weblate items_count for items translation instead of obsolete album_thumbnail_card_item and album_thumbnail_card_items

@dvbthien
Copy link
Contributor

dvbthien commented May 30, 2025 •
edited
Loading

Hi @waclaw66 ,

I noticed that your pull request is using the weblate items_count for item translations instead of the obsolete album_thumbnail_card_item and album_thumbnail_card_items. I've already made this change in PR #18622. This pull request just needs to update the t function to use the current language (instead of always using 'en' as before).

Have a nice day, Thanks!

@waclaw66 waclaw66 force-pushed the fix/items-translation branch from 695aa7e to 0ee7686 Compare June 2, 2025 04:59
@waclaw66 waclaw66 changed the title fix(mobile): items translation fix(mobile): t function localization Jun 2, 2025
@waclaw66
Copy link
Contributor Author

waclaw66 commented Jun 2, 2025

Hi @dvbthien, I have reverted changes regarding items translation and kept only changes related to t function fix.

Hi @waclaw66 ,

I noticed that your pull request is using the weblate items_count for item translations instead of the obsolete album_thumbnail_card_item and album_thumbnail_card_items. I've already made this change in PR #18622. This pull request just needs to update the t function to use the current language (instead of always using 'en' as before).

Have a nice day, Thanks!

alextran1502
alextran1502 reviewed Jun 2, 2025
View reviewed changes
@alextran1502 alextran1502 merged commit edae9c2 into immich-app:main Jun 3, 2025
42 checks passed
savely-krasovsky pushed a commit to savely-krasovsky/immich that referenced this pull request Jun 8, 2025
@waclaw66 @savely-krasovsky
fix(mobile): t function localization (immich-app#18768)
0dfe196 
* fix(mobile): items translation

* Intl.defaultLocale null coalescence
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alextran1502 alextran1502 alextran1502 left review comments

@shenlong-tanwen shenlong-tanwen shenlong-tanwen approved these changes

Assignees

No one assigned

Labels

changelog:bugfix 📱mobile

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@waclaw66 @dvbthien @alextran1502 @shenlong-tanwen