fix: pinch zoom in mobile app #18744
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To properly zoom to current position and pan at the correct speed TODO: zoom to current pinch position
alextran1502
changed the title
savely-krasovsky
pushed a commit
to savely-krasovsky/immich
that referenced
this pull request
Jun 8, 2025
* Change photo zoom logic To properly zoom to current position and pan at the correct speed TODO: zoom to current pinch position * zoom to current pinch position * Clean unused variable * Formatting * fix: lint --------- Co-authored-by: Alex <[email protected]>
waclaw66
added a commit
to waclaw66/immich
that referenced
this pull request
Sep 1, 2025
alextran1502
pushed a commit
that referenced
this pull request
Sep 4, 2025
* fix: pinch + move scale * added lost changes from #18744
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Unfortunately I think I broke more things than I fixed in #18569, sorry for not testing it enough.
Fixes #18730 "always zooms towards the image center". Now zooms to the
focalPoint.I am not sure if or where
widget.enablePanAlwaysistrueor what it should do in that case, but I believe it should only disable the clamping.details.focalPointis relative to top left of the screen, butthis.positionis relative to the center, which is why I calculatecenteredFocalPoint. I didn't find any function that would provide this functionality. The closest one wasscaleBoundaries.outerSize.center(origin)but that one adds half of the size instead of subtracting it.How Has This Been Tested?
Screenshots (if appropriate)
Screen recording after the changes:
screen_recording.mp4
Checklist:
src/services/uses repositories implementations for database calls, filesystem operations, etc.src/repositories/is pretty basic/simple and does not have any immich specific logic (that belongs insrc/services/)