refactor: library-exclusion-pattern-form modal #18654
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
web/src/lib/components/forms/library-exclusion-pattern-form.svelte
Outdated
Show resolved
Hide resolved
Comment on lines
157
to
158
| editExclusionPattern = listIndex; | ||
| editedExclusionPattern = exclusionPattern; | ||
| await onEditExclusionPattern(); |
Member
There was a problem hiding this comment.
In fact you probably don't even need editExclusionPattern anymore, right? Can just pass that to the function?
danieldietzler
changed the title
danieldietzler
approved these changes
May 29, 2025
Member
danieldietzler
left a comment
danieldietzler
left a comment
There was a problem hiding this comment.
Thanks for all the refactorings!
Co-authored-by: Daniel Dietzler <[email protected]>
savely-krasovsky
pushed a commit
to savely-krasovsky/immich
that referenced
this pull request
Jun 8, 2025
Co-authored-by: Daniel Dietzler <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Refactored the library-exclusion-patter modal to the new modalManager