Skip to content

fix(server): handle period in database name #18590

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 27, 2025
Merged

fix(server): handle period in database name #18590

merged 1 commit into from
May 27, 2025

Conversation

mertalev
Copy link
Contributor

sigh

@mertalev mertalev requested a review from danieldietzler as a code owner May 24, 2025 18:44
@danieldietzler
Copy link
Member

What? The conclusion I drew from the issue reply is that we just don't support this shit lol.

@mertalev
Copy link
Contributor Author

What? The conclusion I drew from the issue reply is that we just don't support this shit lol.

It's a trivial change and every other DB reference is correct, so there's no reason to intentionally keep it broken here

bo0tzz
bo0tzz approved these changes May 24, 2025
View reviewed changes
Copy link
Member

@bo0tzz bo0tzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm fine with a one line change but if there end up being more changes needed to handle this then I say at that point we revert this and don't support it :P

@zackpollard zackpollard merged commit e2720e8 into main May 27, 2025
54 of 55 checks passed
@zackpollard zackpollard deleted the fix/database-name-period branch May 27, 2025 15:05
savely-krasovsky pushed a commit to savely-krasovsky/immich that referenced this pull request Jun 8, 2025
@mertalev @savely-krasovsky
fix(server): handle period in database name (immich-app#18590)
94c5ba8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bo0tzz bo0tzz bo0tzz approved these changes

@danieldietzler danieldietzler danieldietzler approved these changes

Assignees
No one assigned
Labels
changelog:bugfix 🗄️server
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mertalev @danieldietzler @bo0tzz @zackpollard