Skip to content

feat: version check endpoint #18572

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 27, 2025
Merged

feat: version check endpoint #18572

merged 1 commit into from
May 27, 2025

Conversation

danieldietzler
Copy link
Member

No description provided.

Copy link
Member

@bo0tzz bo0tzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

micro nit: does this need the -state suffix in the naming? :P

@danieldietzler
Copy link
Member Author

micro nit: does this need the -state suffix in the naming? :P

I initially had it without that suffix and then I saw reverse geocoding has it, so I added it here for consistency 😅

@jrasm91
Copy link
Contributor

jrasm91 commented May 24, 2025

This is an admin only route. I like this here for completeness, but the actual URL 3rd parties should use for checking should probably be a non admin route in the server controller and maybe something like one of these

GET /server/version-check
GET /server/update-status

@danieldietzler danieldietzler force-pushed the feat/version-check-endpoint branch from 11a349d to 6ab6d73 Compare May 25, 2025 10:42
@danieldietzler danieldietzler requested review from jrasm91 and removed request for jrasm91 May 25, 2025 10:43
Copy link
Contributor

@jrasm91 jrasm91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The dto should maybe follow the format we send in the websocket though

@danieldietzler
Copy link
Member Author

The dto should maybe follow the format we send in the websocket though

It does already.

@danieldietzler danieldietzler force-pushed the feat/version-check-endpoint branch from 6ab6d73 to 1394da6 Compare May 26, 2025 10:47
@alextran1502 alextran1502 merged commit 5268dc4 into main May 27, 2025
52 checks passed
@alextran1502 alextran1502 deleted the feat/version-check-endpoint branch May 27, 2025 14:33
savely-krasovsky pushed a commit to savely-krasovsky/immich that referenced this pull request Jun 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants