Skip to content

fix(web): OAuth quota size #18526

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 13, 2025
Merged

fix(web): OAuth quota size #18526

merged 1 commit into from
Jun 13, 2025

Conversation

wuzihao051119
Copy link
Contributor

Fixes #18504.

danieldietzler
danieldietzler reviewed May 23, 2025
View reviewed changes
Copy link
Member

@danieldietzler danieldietzler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's more reasonable to just drop the default quota field. If the claim isn't provided it's unlimited, otherwise it's whatever the claim is.

@wuzihao051119 wuzihao051119 force-pushed the fix-oauth-quota-size branch 2 times, most recently from ac9af24 to 3b88e3a Compare May 23, 2025 15:27
@github-actions github-actions bot added the documentation Improvements or additions to documentation label May 23, 2025
@wuzihao051119 wuzihao051119 force-pushed the fix-oauth-quota-size branch from e3f7d2d to 0890d01 Compare May 23, 2025 15:57
@wuzihao051119
Copy link
Contributor Author

Done.

danieldietzler
danieldietzler reviewed May 24, 2025
View reviewed changes
@alextran1502 alextran1502 requested a review from jrasm91 May 25, 2025 19:38
jrasm91
jrasm91 reviewed Jun 12, 2025
View reviewed changes
Copy link
Member

@jrasm91 jrasm91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you help implement the suggested changes? ie make the property nullable and have null imply no storage quota, instead of 0.

@wuzihao051119 wuzihao051119 force-pushed the fix-oauth-quota-size branch from 1c5aba5 to 0532d9c Compare June 13, 2025 05:20
@wuzihao051119
Copy link
Contributor Author

Okay, I have implemented the suggested changes.

jrasm91
jrasm91 approved these changes Jun 13, 2025
View reviewed changes
Copy link
Member

@jrasm91 jrasm91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jrasm91 jrasm91 merged commit 004c2f2 into immich-app:main Jun 13, 2025
47 checks passed
@wuzihao051119 wuzihao051119 deleted the fix-oauth-quota-size branch June 13, 2025 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danieldietzler danieldietzler danieldietzler left review comments

@jrasm91 jrasm91 jrasm91 approved these changes

Assignees
No one assigned
Labels
changelog:enhancement documentation Improvements or additions to documentation 🗄️server 🖥️web
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

OAuth: DEFAULT STORAGE QUOTA does not permit 0GB accounts
3 participants
@wuzihao051119 @jrasm91 @danieldietzler