feat(web): make google cast opt in #18514
Conversation
this isnt bound to anything yet
github-actions
bot
added
the
documentation
bwees
added
changelog:enhancement
and removed
documentation
github-actions
bot
added
the
documentation
|
Honestly, I don’t agree with making this disabled by default. I do understand the privacy concerns and I think providing a way to disable it is necessary. If it’s disabled by default, a large portion of users will never realize that it exists. |
|
What if we had 3 states? disabled (default), enabled, and hidden? In disabled mode, the button would still be visible on the asset page and on click it would say "Google cast is disabled by default. Would you like to enable? Y/N/Never ask again (which would change state to hidden and hide the icon moving forward). At least the way I am picturing this PR, the icon would never be seen unless the user goes into settings to enable feature. |
we need to mock user prefs since CastButton uses it
I like this idea. It lets the user discover the feature naturally at their own pace and informs them why they would or wouldn't want it. Being able to continue showing the icon also means they can decline for now and leave it as a reminder without needing to make a more lasting decision they might forget about. |
Yes, this seems perfect. The biggest thing is that nothing hits Google's server until you agree. Also, is this going to be a user option or a server option? |
alextran1502
left a comment
alextran1502
left a comment
There was a problem hiding this comment.
Merging this for now, will make an onboarding flow to let users know of this feature
* add setting switch this isnt bound to anything yet * make google casting opt-in * doc updates * lint docs * remove unneeded translation items * update mobile openai defs * fix failing test we need to mock user prefs since CastButton uses it
Description
We load Google provided JS code to check if we can present Google Cast as a cast destination. This hits Google servers when you load the web ui. This is a privacy concern for some and thus should be opt-in. Google cast is now opt-in via Account Settings > Features > Cast > Google Cast toggle.
Fixes discord report
How Has This Been Tested?
Tested on local dev build. Once the setting is changed, a refresh will load/unload the Google scripts.
Screenshots (if appropriate)
Checklist:
src/services/uses repositories implementations for database calls, filesystem operations, etc.src/repositories/is pretty basic/simple and does not have any immich specific logic (that belongs insrc/services/)