Skip to content

fix(mobile): chinese translation #18491

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 23, 2025
Merged

fix(mobile): chinese translation #18491

merged 2 commits into from
May 23, 2025

Conversation

alextran1502
Copy link
Contributor

@alextran1502 alextran1502 commented May 22, 2025

Fixes #18445

Traditional

image

Simplified

image

@alextran1502
Copy link
Contributor Author

@zlewe @GITHUBNULLING @nick322 Can you guys help check if the languages are correct from the screenshots?

@wuzihao051119
Copy link
Collaborator

wuzihao051119 commented May 22, 2025

I can confirm it has been fixed. But further fix is needed (See details in #18197).

@zlewe
Copy link
Contributor

zlewe commented May 23, 2025

The language is correct from the screenshot but this fix is effectively a partial rollback of #18167 that fixes the "stickiness" of zh_TW/Hant setting (But caused this current bug as a side effect.).

One simple solution is proposed in #18197, which Locale.fromSubtags is used instead.

@nick322
Copy link
Contributor

nick322 commented May 23, 2025

Can you guys help check if the languages are correct from the screenshots?

The screenshot is correct.

@zackpollard zackpollard changed the title fix: Chinese translation fix: chinese translation May 23, 2025
@zackpollard zackpollard changed the title fix: chinese translation fix(mobile): chinese translation May 23, 2025
@alextran1502 alextran1502 merged commit 2fa7a40 into main May 23, 2025
49 checks passed
@alextran1502 alextran1502 deleted the fix-18445 branch May 23, 2025 13:01
@Xizicl
Copy link

Xizicl commented May 23, 2025

@alextran1502 Hi~Can I know that When will the new version of this merge be released?

@alextran1502
Copy link
Contributor Author

@Xizicl Sometimes this weekend, I assume, we will push out the release today but then the app stores will need to review and publish it

savely-krasovsky pushed a commit to savely-krasovsky/immich that referenced this pull request Jun 8, 2025
* fix: Chinese translation

* using Locale.fromsubtags
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ios更新到v1.133.0后设置的中文失效了
6 participants