Skip to content

fix(web): multi-select #18485

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 22, 2025
Merged

Conversation

wuzihao051119
Copy link
Collaborator

Fix wrong behavior in using shift key to select multi-asset.
Correct:

correct.mp4

Wrong:

wrong.mp4

Selecting asset in range (beginBucket, endBucket) and Selecting dateGroup in range [beginBucket, endBucket] is correct logic.

@alextran1502
Copy link
Contributor

I can't reproduce this issue

@wuzihao051119
Copy link
Collaborator Author

wuzihao051119 commented May 22, 2025

The key point to reproduce this is:

  1. selecting the non-first photo in the bucket when selecting the start photo (pay attention to the selection icon in the thumbnail)
  2. selecting the photo in the non-first dateGroup in the bucket when selecting the end photo (pay attention to the selection icon in the dateGroup).

@alextran1502
Copy link
Contributor

Ah got cha

@alextran1502 alextran1502 merged commit c7dc311 into immich-app:main May 22, 2025
49 of 50 checks passed
@wuzihao051119 wuzihao051119 deleted the fix-multi-select branch May 22, 2025 20:18
savely-krasovsky pushed a commit to savely-krasovsky/immich that referenced this pull request Jun 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants