-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
fix(server): bump sharp #17818
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(server): bump sharp #17818
Conversation
My server in Docker (ARM64) crashed on every start because this error: |
Can confirm that this works on arm64 when deployed through the k8s Helm Chart. Thanks for the quick fix! |
It "works", but it uses the wrong library so there are a lot of regressions in supported image formats. I think the issue might be that there's a transitive dependency on sharp that's resulting in it trying to install different versions of sharp... |
Oh I see, seems to be a dependency of react-email => next => sharp 0.33.5. Would me keeping my staging version of Immich pinned to this PR be of any help to you? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Feel free to merge for patch release when confirmed that it works
Can you see if the latest image works? |
sure, ghcr.io/immich-app/immich-server:commit-7c6583e9a0b46a79c011039b870c618dbd90d566 works fine, heic and dng previews are generated as usual, thanks! |
* bump sharp * test linking * link in prod image too * force global * keep unnecessary libraries * override sharp version * revert dockerfile changes * add node-gyp and napi * dev dependency
Description
We upgraded libvips, but haven't upgraded sharp along with it. This may be causing installation issues.
Tested and working on a RK3588 board.