-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
fix(mobile): revert cache fixes #17786
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
alextran1502
commented
Apr 22, 2025
- Revert "fix(mobile): use immutable cache keys for local images (fix(mobile): use immutable cache keys for local images #17736)"
- Revert "perf(mobile): remove small thumbnail and cache generated thumbnails (perf(mobile): remove small thumbnail and cache generated thumbnails #17682)"
This reverts commit 010b144.
During my test round for release, I identified issues when the two PRs are combined.
I think this issue will take some time to investigate and come up with the right solution, so I revert these two PRs to prepping for the release |
@alextran1502 That's interesting. Is it confirmed that 2 PRs conflict cause problems together or it might just be that only one of them is problematic? |
@lukaszwawrzyk they caused the two issue I describe. Your PR caused the issue with the thumbnails render the same asset in the album selection view, and the other with a custom cache implementation caused issue of incorrect thumbnail displayed |
@alextran1502 Can it be can the local id of an asset can be equal on two accounts? So Image A could have the local ID 001 on account X and Image B has also the local ID 001 but on account B. |
@alextran1502 It would be great to have to actual functionality with the caching. If you can wait until tomorrow I would he happy to open another PR with my changes and the caching key adapted to use the user id as well. Then this behavor will be fixed. |
@EinToni I am planning for a release tomorrow afternoon CTS timezone. If you can put it in before that, I can help with testing |
@alextran1502 Okay thank you I opened another PR with the respective changes. I'm in UTC+2 so I'll go to bed now, but will do all I can to get this merged tomorrow :D |
@alextran1502 #17794 I fixed my PR too, I tested my scenario and scenario that you reported as broken and it seems to work fine. |
* Revert "fix(mobile): use immutable cache keys for local images (immich-app#17736)" This reverts commit 010b144. * Revert "perf(mobile): remove small thumbnail and cache generated thumbnails (immich-app#17682)" This reverts commit b71039e.