Skip to content

chore(mobile): don't show drag scroll date in search page #17594

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 14, 2025

Conversation

EinToni
Copy link
Contributor

@EinToni EinToni commented Apr 14, 2025

Description

  • When using the drag scroll, the date of the current image is shown. This is now made toggleable.
  • For the mobile search result page, the display of the date is now disabled because the results are not sorted by date and therefore a display of the date is not desirable.

Fixes #10379

How Has This Been Tested?

Tested on virtual mobile device by using the search function. The results are shown in the screenshots below.

Screenshots

The drag scroll on the main screen (as an example):
mainScreenScroll

The drag scroll with disabled label on the search results screen:
searchResultsScroll

Checklist:

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation if applicable
  • I have no unrelated changes in the PR.
  • I have confirmed that any new dependencies are strictly necessary.
  • I have written tests for new code (if applicable)
  • I have followed naming conventions/patterns in the surrounding code
  • All code in src/services/ uses repositories implementations for database calls, filesystem operations, etc.
  • All code in src/repositories/ is pretty basic/simple and does not have any immich specific logic (that belongs in src/services/)

* When using the drag scroll, the date of the current image is shown. This is now made toggleable.
* For the mobile search result page, the display of the date is now disabled because the results are not sorted by date and therefore a display of the date is not desirable.
@alextran1502 alextran1502 changed the title Dont show drag scroll date in search page chore(mobile): don't show drag scroll date in search page Apr 14, 2025
@alextran1502 alextran1502 enabled auto-merge (squash) April 14, 2025 18:45
@alextran1502 alextran1502 merged commit aad5c3b into immich-app:main Apr 14, 2025
42 of 44 checks passed
savely-krasovsky pushed a commit to savely-krasovsky/immich that referenced this pull request Jun 8, 2025
…#17594)

Dont show drag scroll date in search page

* When using the drag scroll, the date of the current image is shown. This is now made toggleable.
* For the mobile search result page, the display of the date is now disabled because the results are not sorted by date and therefore a display of the date is not desirable.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mobile: search results display date when scrubbing scroll bar
2 participants