feat(server): parse EXIF creation time for some insta360 images #17564
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kirens
force-pushed
the
feat/insta360-exif
branch
from
1627317 to
11e299e
Compare
It seems insta360 stores metadata in XMP GPano tags, with their own non-standard and undocumented addition `SourceImageCreateTime`. For some pictures this is the only EXIF tag containing a creation time.
Kirens
force-pushed
the
feat/insta360-exif
branch
from
11e299e to
edce04e
Compare
|
Thought I was safe having run |
alextran1502
approved these changes
Apr 13, 2025
jrasm91
approved these changes
Apr 14, 2025
savely-krasovsky
pushed a commit
to savely-krasovsky/immich
that referenced
this pull request
Jun 8, 2025
…ch-app#17564) It seems insta360 stores metadata in XMP GPano tags, with their own non-standard and undocumented addition `SourceImageCreateTime`. For some pictures this is the only EXIF tag containing a creation time.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Some insta360 panoramas are not placed correctly in the timeline. This is because the creation date is stored in a metadata tag unknown to immich. It seems insta360 stores metadata in XMP GPano tags, with their own non-standard and undocumented addition
SourceImageCreateTime.The tag is already parsed by exiftool-vendored. By adding it to
EXIF_DATE_TAGSit becomes a possible source of the creation date when processing image metadata.We can find traces of this tag in their ios-SDK repo. There's also a commit to Panoramax GeoPic Tag Reader that adds support for this tag which may provide context, and another example image.
How Has This Been Tested?
Checklist:
src/services/uses repositories implementations for database calls, filesystem operations, etc.src/repositories/is pretty basic/simple and does not have any immich specific logic (that belongs insrc/services/)