fix: patch-package install in docker build and better postgres patch #17523
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrasm91
changed the title
jrasm91
approved these changes
Apr 10, 2025
…f directory so post install doesnt run
… copy the patches folder for the docker build to use and patch with
…f it does not exist
bwees
force-pushed
the
postgres-patch-package-fixes
branch
from
b426f33 to
ddf9176
Compare
…o parse and reject
3 tasks
savely-krasovsky
pushed a commit
to savely-krasovsky/immich
that referenced
this pull request
Jun 8, 2025
…mmich-app#17523) * always patch package when running npm i, install immich CLI outside of directory so post install doesnt run * handles case where query is an object and defined but origin is not. * move patch-package from a dev dependency to a normal dependency. Also copy the patches folder for the docker build to use and patch with * fix Dockerfile * use query.reject instead of throw for queryError * package-lock to reflect the dev dependency change * dont throw the error, just provide an empty string for query.origin if it does not exist * remove npm link and demote patch-package back to a dev dependency * modify patch to add defensive check to catch queries that will fail to parse and reject
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
patch-packageis not running on the docker build currently. This is due to the check on our post-install script to prevent it from running if a global install is triggered. It turns out that the build is failing onnpm linkinstead of the global install as we previously thought.This PR promotes patch-package to a normal dependency instead of a dev-dependency so it is able to patch packages when only regular (non-dev) dependencies are installed. In addition, we must also copy the patches folder for the build step to use.
This also adds a check for if query is an object but
query.origindoes not exist (described here: porsager/postgres#944 (comment)).Fixes report from discord: https://discord.com/channels/979116623879368755/1359070399916146729/1359701229504303377)
How Has This Been Tested?
I have tested and confirmed that the relevant files are properly patched at the end of the docker build. Still need an action to be run here to confirm the whole pipeline works.
Checklist:
src/services/uses repositories implementations for database calls, filesystem operations, etc.src/repositories/is pretty basic/simple and does not have any immich specific logic (that belongs insrc/services/)