fix: test_sets_default_sess_options fails if compiling with globally enabled cuda #17516
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…enabled cuda Coming from nixos, this test fails when cuda is enabled. NixOS/nixpkgs#382896 Solution as proposed by @mertalev
mertalev
approved these changes
Apr 10, 2025
savely-krasovsky
pushed a commit
to savely-krasovsky/immich
that referenced
this pull request
Jun 8, 2025
…enabled cuda (immich-app#17516) Coming from nixos, this test fails when cuda is enabled. NixOS/nixpkgs#382896 Solution as proposed by @mertalev
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Coming from nixos, this test fails when cuda is enabled. NixOS/nixpkgs#382896
Solution as proposed by @mertalev
Description
I'm not super familiar with how the plumbing of this all works, but in nixos tests are failing when we build the system with cuda support, so lets limit this test to the CPU provider only. I think that makes sense to only assume sess options when using the cpu provider, anyways.
Fixes NixOS/nixpkgs#352113
How Has This Been Tested?
Running my builds with this PR as patch now. I will update here when finished.
Screenshots (if appropriate)
Checklist:
src/services/uses repositories implementations for database calls, filesystem operations, etc.src/repositories/is pretty basic/simple and does not have any immich specific logic (that belongs insrc/services/)