Skip to content

feat: use browser download manager for single file downloads #17507

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 10, 2025
Merged

feat: use browser download manager for single file downloads #17507

merged 3 commits into from
Apr 10, 2025
+17 −18

Conversation

ROODAY
Copy link
Contributor

@ROODAY ROODAY commented Apr 9, 2025 •
edited
Loading

Description

How Has This Been Tested?

  • Uploaded large video file and small image file. Downloading files immediately opens browser download UI and skips Immich download manager. For archives, the download manager progress bar properly updates. Once reaching 100%, the browser download UI opens and performs the final download/move operation.

Screenshots (if appropriate)

Checklist:

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation if applicable
  • I have no unrelated changes in the PR.
  • I have confirmed that any new dependencies are strictly necessary.
  • I have written tests for new code (if applicable)
  • I have followed naming conventions/patterns in the surrounding code
  • All code in src/services/ uses repositories implementations for database calls, filesystem operations, etc.
  • All code in src/repositories/ is pretty basic/simple and does not have any immich specific logic (that belongs in src/services/)

@ROODAY ROODAY force-pushed the rooday/web-direct-downloads branch from 6258a47 to eddaf65 Compare April 9, 2025 23:34
@ROODAY ROODAY marked this pull request as ready for review April 9, 2025 23:38
@ROODAY ROODAY changed the title Directly download files without buffering in memory Skip XHR request for individual file downloads and fix download manager reactivity Apr 9, 2025
@jrasm91 jrasm91 changed the title Skip XHR request for individual file downloads and fix download manager reactivity feat: use browser download manager for single file downloads Apr 10, 2025
@ROODAY ROODAY requested a review from danieldietzler as a code owner April 10, 2025 00:57
@ROODAY ROODAY force-pushed the rooday/web-direct-downloads branch from cfc9de3 to 885b67c Compare April 10, 2025 00:59
@alextran1502 alextran1502 merged commit 9e49783 into immich-app:main Apr 10, 2025
40 checks passed
@jrasm91 jrasm91 mentioned this pull request Apr 10, 2025
Closed
4 tasks
savely-krasovsky pushed a commit to savely-krasovsky/immich that referenced this pull request Jun 8, 2025
@ROODAY @savely-krasovsky
feat: use browser download manager for single file downloads (immich-…
ff9dcd1 
…app#17507)

* Fix download panel reactivity

* Directly download individual files without buffering in memory

* Fix shared link e2e download tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jrasm91 jrasm91 jrasm91 approved these changes

@danieldietzler danieldietzler danieldietzler approved these changes

Assignees
No one assigned
Labels
changelog:enhancement 🖥️web
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Download design issue
4 participants
@ROODAY @jrasm91 @danieldietzler @alextran1502