Skip to content

fix(web): Video memories are played at 100% volume instead of respecting user preference #17424

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 7, 2025

Conversation

Zlendy
Copy link
Contributor

@Zlendy Zlendy commented Apr 6, 2025

Description

Fixes videos in memory-viewer.svelte playing at 100% volume instead of using $videoViewerVolume to respect user preference.

Fixes #17423

How Has This Been Tested?

  1. Set video player volume to any value
  2. Open a video memory
  3. Video memory is played at the preferred volume instead of 100%

Screenshots (if appropriate)

Checklist:

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation if applicable
  • I have no unrelated changes in the PR.
  • I have confirmed that any new dependencies are strictly necessary.
  • I have written tests for new code (if applicable)
  • I have followed naming conventions/patterns in the surrounding code
  • All code in src/services/ uses repositories implementations for database calls, filesystem operations, etc.
  • All code in src/repositories/ is pretty basic/simple and does not have any immich specific logic (that belongs in src/services/)

@danieldietzler
Copy link
Member

Thanks for the PR! Just as an FYI you generally don't need to create an issue first before opening a PR here :)

@Zlendy
Copy link
Contributor Author

Zlendy commented Apr 6, 2025

I didn't know that @danieldietzler, I will keep that in mind for future contributions, thanks!

Copy link
Collaborator

@YarosMallorca YarosMallorca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this fix!
I didn't have this in mind when implementing video memories in #16500

@danieldietzler
Copy link
Member

I didn't know that @danieldietzler, I will keep that in mind for future contributions, thanks!

To be clear it definitely isn't bad! Just as an FYI that you don't need to put in the extra effort.

@alextran1502 alextran1502 merged commit b87ba68 into immich-app:main Apr 7, 2025
43 of 44 checks passed
midzelis pushed a commit that referenced this pull request Apr 10, 2025
@Zlendy Zlendy deleted the memory/video-volume branch April 20, 2025 18:07
savely-krasovsky pushed a commit to savely-krasovsky/immich that referenced this pull request Jun 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Video memories are played at 100% volume instead of respecting user preference
4 participants