feat: sync pictureFile with oidc if it isn't set already #17397
Merged
+133
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Edit, I will try to put the picture in the profile folder, it's a bit cleaner. I do not know if it will suffice for it to be auto-cleaned upon user deletion or if I need to do something in addition. |
It does. I need to fix the tests now and I think it will be good to go |
Etienne-bdt
force-pushed
the
oidc-register-picture-sync
branch
from
ba53c32 to
b9d24cb
Compare
fix: move picture writer to get userId fix: move await promise to the top of the setPicure function before checking its value and automatically create the user folder chore: code cleanup
jrasm91
force-pushed
the
oidc-register-picture-sync
branch
from
2a9e19b to
ea5cba5
Compare
jrasm91
approved these changes
Apr 11, 2025
alextran1502
approved these changes
Apr 11, 2025
savely-krasovsky
pushed a commit
to savely-krasovsky/immich
that referenced
this pull request
Jun 8, 2025
…17397) * feat: sync pictureFile with oidc if it isn't set already fix: move picture writer to get userId fix: move await promise to the top of the setPicure function before checking its value and automatically create the user folder chore: code cleanup * fix: extension double dot --------- Co-authored-by: Jason Rasmussen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Syncs
profile.pictureto the filesystem and updatesuser.profileImagePathaccordingly. It will do this if the user doesn't already have a profile image path. This logic runs on every login.