fix(server): full-size images not migrated or deleted correctly #17308
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mertalev
changed the title
danieldietzler
approved these changes
Apr 1, 2025
|
I just ran migration on a fresh server before this fix - is it better to just re-backup my ~2k assets? |
|
@TheXRMonk Can you access your instance in incognito mode? scroll through the timeline and see if the thumbnails loaded? If not, you can run the Thumbnail Generation job for all and it should fixes the issue |
kirill-dev-pro
pushed a commit
to kirill-dev-pro/immich-but-with-public-albums-within-instance
that referenced
this pull request
Apr 6, 2025
…ch-app#17308) * fix file path logic * update tests * add empty array fallback just in case for now
savely-krasovsky
pushed a commit
to savely-krasovsky/immich
that referenced
this pull request
Jun 8, 2025
…ch-app#17308) * fix file path logic * update tests * add empty array fallback just in case for now
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The migration code uses a ternary operator, assuming there are only two file types. This is no longer true, so it doesn't behave correctly. This PR fixes this and refactors usages of
getAssetFilesthat only care about one file to retrieve that file instead. Also fixes the full-size images not being deleted during asset deletion.Fixes #17301