fix(mobile): getAllByRemoteId return all assets on empty arguments value #17263
+42
−37
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alextran1502
changed the title
alextran1502
changed the title
shenlong-tanwen
approved these changes
Apr 1, 2025
There was a problem hiding this comment.
This is actually a weird behaviour with the anyOf modifier from Isar which returns all the entries when the passed Id is empty. Might probably worth fixing it in all other places to have a consistent behaviour, or we can fix them as they come until we migrate everything to Sqlite :)
kirill-dev-pro
pushed a commit
to kirill-dev-pro/immich-but-with-public-albums-within-instance
that referenced
this pull request
Apr 6, 2025
…lue (immich-app#17263) * chore: post release tasks * fix(mobile): getAllByRemoteId return all assets if ids is empty
savely-krasovsky
pushed a commit
to savely-krasovsky/immich
that referenced
this pull request
Jun 8, 2025
…lue (immich-app#17263) * chore: post release tasks * fix(mobile): getAllByRemoteId return all assets if ids is empty
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes an issue where
getAllByRemoteIdwill return all assets if theidsargument is empty.