fix: MAX_PARAMETERS_EXCEEDED error during person cleanup job #17222
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rvices:{}] Unable to run job handler (backgroundTask/person-cleanup): Error: MAX_PARAMETERS_EXCEEDED: Max number of parameters (65534) exceeded
|
There's a |
Ok, let me take a look |
zackpollard
approved these changes
Mar 31, 2025
zackpollard
changed the title
kirill-dev-pro
pushed a commit
to kirill-dev-pro/immich-but-with-public-albums-within-instance
that referenced
this pull request
Apr 6, 2025
…app#17222) * add batch size in sql delete,fix person cleanup error: ERROR [Microservices:{}] Unable to run job handler (backgroundTask/person-cleanup): Error: MAX_PARAMETERS_EXCEEDED: Max number of parameters (65534) exceeded * add chunked decorator to delete * chore: prettier formatting fixes --------- Co-authored-by: hwang3419 <“[email protected]”> Co-authored-by: Zack Pollard <[email protected]>
savely-krasovsky
pushed a commit
to savely-krasovsky/immich
that referenced
this pull request
Jun 8, 2025
…app#17222) * add batch size in sql delete,fix person cleanup error: ERROR [Microservices:{}] Unable to run job handler (backgroundTask/person-cleanup): Error: MAX_PARAMETERS_EXCEEDED: Max number of parameters (65534) exceeded * add chunked decorator to delete * chore: prettier formatting fixes --------- Co-authored-by: hwang3419 <“[email protected]”> Co-authored-by: Zack Pollard <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix MAX_PARAMETERS_EXCEEDED error while running person cleanup job
When deleting a large list of people id, the cleanup job would fail
error logs looks like this:
2025-03-29 09:52:26 immich_server | '0035574c-d90a-4a26-a59d-3048a12e0ce5',
2025-03-29 09:52:26 immich_server | '0035fe2c-1f2b-4e69-b434-471d6f90c131',
2025-03-29 09:52:26 immich_server | '00363762-0202-4700-a8da-01b30e5b96e3',
2025-03-29 09:52:26 immich_server | '00366197-c46e-4d0e-bb0d-9db38f969f26',
2025-03-29 09:52:26 immich_server | ... 107324 more items
2025-03-29 09:52:26 immich_server | ]
2025-03-29 09:52:26 immich_server | }
2025-03-29 09:52:26 immich_server | [Nest] 7 - 03/29/2025, 2:52:26 PM WARN [Microservices:StorageRepository] File upload/thumbs/17b74790-7821-4f2f-977e-5256626dc7c4/ff/fe/fffe2196-63d9-42c7-b0c4-d008fbd99146.jpeg does not exist.
2025-03-29 09:52:26 immich_server | [Nest] 7 - 03/29/2025, 2:52:26 PM ERROR [Microservices:{}] Unable to run job handler (backgroundTask/person-cleanup): Error: MAX_PARAMETERS_EXCEEDED: Max number of parameters (65534) exceeded
Fixes # (issue)
How Has This Been Tested?
Screenshots (if appropriate)
Checklist:
src/services/uses repositories implementations for database calls, filesystem operations, etc.src/repositories/is pretty basic/simple and does not have any immich specific logic (that belongs insrc/services/)