Skip to content

fix(mobile): prefer remote orientation #17177

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 28, 2025
Merged

Conversation

shenlong-tanwen
Copy link
Member

Description

  • If an asset is already backed up, prefer the orientation from the server as it is more likely to be correct than the one from photo_manager, which might return invalid values

@alextran1502
Copy link
Contributor

Can you test this with local-only, remote-only, and merged assets for vertical and horizontal videos and ensure their aspect ratio is correct?

@alextran1502 alextran1502 merged commit c8331f1 into main Mar 28, 2025
44 checks passed
@alextran1502 alextran1502 deleted the fix/aspect-ratio-android branch March 28, 2025 15:24
kirill-dev-pro pushed a commit to kirill-dev-pro/immich-but-with-public-albums-within-instance that referenced this pull request Apr 6, 2025
* fix(mobile): prefer remote orientation

* pr feedback

---------

Co-authored-by: shenlong-tanwen <[email protected]>
savely-krasovsky pushed a commit to savely-krasovsky/immich that referenced this pull request Jun 8, 2025
* fix(mobile): prefer remote orientation

* pr feedback

---------

Co-authored-by: shenlong-tanwen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants