-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
feat(mobile): sqlite #16861
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(mobile): sqlite #16861
Conversation
343fce0
to
9366699
Compare
04d21e5
to
beecccd
Compare
Also, we probably want STRICT, WAL mode and WITHOUT ROWID enabled for all tables for sanity. |
3700926
to
9623816
Compare
202f7b8
to
28b9fc8
Compare
A small heads-up, in the last commit, I've moved the common Drift table overrides to a mixin and applied it to all three drift entities. This should make it easier to apply them for the newer entities. |
* refactor: user entity * chore: rebase fixes * refactor: remove int user Id * refactor: migrate store userId from int to string * refactor: rename uid to id * feat: drift * pr feedback * refactor: move common overrides to mixin --------- Co-authored-by: shenlong-tanwen <[email protected]>
Does this apply to the iphone app? Sorry I don't use iphone so asking if I should advise my users. |
Are you sure this comment is meant for this PR? Either ways, we are in the process of migrating our local database from Isar to Sqlite and is common for both Android and iOS |
I was asking in reference to the release notes of v1.132.0 where it is stated that a switch to sqlite was made. As well in reference to #13369 that presently the iPhone app is very slow. So the question was whether this switch to sqlite is supposed to improve iphone mobile app scalability or this is not expected to affect it. |
I see, Thanks for the clarification. Yes, this is the first of many PRs in migrating to Sqlite. We do not use it yet, but hopefully, after few more releases, you should see some good improvements in the performance of the mobile app |
Is there a high level description how it is supposed to work? Because I read Isar is famous for being fast although unsupported. So it's really interesting. |
* refactor: user entity * chore: rebase fixes * refactor: remove int user Id * refactor: migrate store userId from int to string * refactor: rename uid to id * feat: drift * pr feedback * refactor: move common overrides to mixin --------- Co-authored-by: shenlong-tanwen <[email protected]>
Description