fix(docs): logo not loading dark theme variant in production #16820
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NicholasFlamy
added
documentation
jrasm91
approved these changes
Mar 11, 2025
knechtandreas
added a commit
to knechtandreas/immich
that referenced
this pull request
Mar 13, 2025
…s-broken * main: (41 commits) chore(deps): update typescript-projects (immich-app#16795) fix: immich ui toggles and switches (immich-app#16834) feat: better library rename UX (immich-app#16837) refactor: use immich/ui button component in user settings (immich-app#16836) chore(mobile): bump dependency versions (immich-app#16823) fix(web): fixed formatting of video length (immich-app#16829) refactor: user entity (immich-app#16655) fix(web): update search results when searching from info panel (immich-app#16729) fix(docs): logo not loading dark theme variant in production (immich-app#16820) refactor: use factory and kysely types for partner repository (immich-app#16812) fix(ml): dev environment dependencies (immich-app#16815) fix: run preview label remove job on PR close (immich-app#16811) feat(web): Add keyboard shortcut selection on grid (immich-app#16713) feat(web): better person naming interface (immich-app#16631) chore(mobile): use path provider foundation (immich-app#16804) chore(mobile): add orientation tests for exif (immich-app#16806) chore: ignore correct build folder (immich-app#16808) fix(server): set unit test timezone to UTC (immich-app#16805) chore: shared suffix for docker tags (immich-app#16727) chore(deps): update base-image to v20250311 (major) (immich-app#16803) ...
savely-krasovsky
pushed a commit
to savely-krasovsky/immich
that referenced
this pull request
Jun 8, 2025
…app#16820) fix logo not loading dark theme variant in production
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The logo on the docs shows the light theme logo if you open the page or refresh the page with dark theme enabled. If you run
npm run startit doesn't occur because JS is run on the client.This PR switches to the official docusaurus component for themed images: https://docusaurus.io/docs/markdown-features/assets#themed-images
How Has This Been Tested?
Screenshots
Old behavior (after reloading page or loading with dark theme already enabled):
New behavior:
Checklist:
src/services/uses repositories implementations for database calls, filesystem operations, etc.src/repositories/is pretty basic/simple and does not have any immich specific logic (that belongs insrc/services/)