fix: update renderlist after asset deleted #16786
Merged
+5
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -263,10 +263,6 @@ class GalleryViewerPage extends HookConsumerWidget { | |||
| PhotoViewGalleryPageOptions buildAsset(BuildContext context, int index) { | |||
| var newAsset = loadAsset(index); | |||
|
|
|||
| WidgetsBinding.instance.addPostFrameCallback((_) { | |||
There was a problem hiding this comment.
If this logic is removed, would any logic in the currentAssetProvider won't be using the correct asset when navigating between them?
There was a problem hiding this comment.
I believe this is handled by the onpagechanged callback which is called when swiping through the images, but not after an asset has been trashed/deleted:
|
Just a small demonstration how the current implementation can cause issues. When swiping a bit and the hitting delete, the wrong image is being trashed. Screenrecorder-2025-03-25-15-37-44-783.mp4 |
mertalev
approved these changes
Mar 28, 2025
4 tasks
kirill-dev-pro
pushed a commit
to kirill-dev-pro/immich-but-with-public-albums-within-instance
that referenced
this pull request
Apr 6, 2025
savely-krasovsky
pushed a commit
to savely-krasovsky/immich
that referenced
this pull request
Jun 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
#15597 contains a change that fixes the deletion of a single asset (previously the app correctly showed the following image, but in the background the old image was still referenced). However, as it was correctly pointed out, this change would also set the new asset on every little swipe, which could also lead to incorrect behaviour.
I have now moved the logic to a (in my view) more appropriate place, where it only applies when an image is being deleted.
Fixes #17193
How Has This Been Tested?
Screenshots (if appropriate)
Checklist:
src/services/uses repositories implementations for database calls, filesystem operations, etc.src/repositories/is pretty basic/simple and does not have any immich specific logic (that belongs insrc/services/)