feat(web): remember search context #16614
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
YarosMallorca
approved these changes
Mar 6, 2025
Collaborator
YarosMallorca
left a comment
YarosMallorca
left a comment
There was a problem hiding this comment.
Tested locally, works as expected.
alextran1502
changed the title
mertalev
reviewed
Mar 6, 2025
web/src/lib/components/shared-components/search-bar/search-filter-modal.svelte
Outdated
Show resolved
Hide resolved
web/src/lib/components/shared-components/search-bar/search-filter-modal.svelte
Show resolved
Hide resolved
mertalev
approved these changes
Mar 6, 2025
Member
|
Added the element to show the current search type on the search bar for clarity 
|
knechtandreas
added a commit
to knechtandreas/immich
that referenced
this pull request
Mar 10, 2025
…s-broken * main: fix(server): set the dev server restart policy of the dev server container to match the other containers (immich-app#16753) feat(web): remember search context (immich-app#16614) feat(server): read Android and Sony video camera make/model (immich-app#16678) fix(server): adjust type of person.birthDate (immich-app#16628) fix(web): add labels to memory lane buttons (immich-app#16664) feat(mobile): locate in timeline (immich-app#16722) chore(ml): uv (immich-app#16725) fix: 🍪 packages confusion (immich-app#16735) fix(web): Update people-card favorite position (immich-app#16746) chore(mobile): upgrade riverpod (immich-app#16742) chore(mobile): upgrade flutter_web_auth_2 (immich-app#16741) fix(docs): edge case when restoring dump that is unreadable as current user (immich-app#16758)
savely-krasovsky
pushed a commit
to savely-krasovsky/immich
that referenced
this pull request
Jun 8, 2025
* Retain search context in LocalStorage. * Remove debug logging * Prettier * Added QueryType and VALID_QUERY_TYPES to $lib/constants * Prettier * Renamed VALID_QUERY_TYPES to fit the codestyle. Ran prettier * show current search type on search bar * fix: linting --------- Co-authored-by: Alex Tran <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changes
Update the search bar to remember the "Search Type" outside of the filter modal.
Why is this change required? What problem does it solve?
Raised in #16602 , it's a QOL feature. Appreciated more for people who frequently search by non-context means, eg, those without HW-accel ML
If it fixes an open issue, please link to the issue here.
#16602
How Has This Been Tested?
Live-tested UI, with it remote linked to my prod-immich running v1.128.0
https://github.com/user-attachments/assets/069d40d1-85be-4317-9a17-2e1b42adb0be
Unit tests
npm run testnpm run check:allNo issues for the files changed in this PR
Checklist:
src/servicesuses repositories implementations for database calls, filesystem operations, etc.src/repositories/is pretty basic/simple and does not have any immich specific logic (that belongs insrc/services)