fix: storage template failure after re-upload and previous fail #16611
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zackpollard
force-pushed
the
fix/storage-template-conflicts
branch
from
db9a679 to
58589bd
Compare
zackpollard
force-pushed
the
fix/storage-template-conflicts
branch
from
58589bd to
c18b445
Compare
zackpollard
force-pushed
the
fix/storage-template-conflicts
branch
from
c18b445 to
d97aa82
Compare
jrasm91
approved these changes
Mar 5, 2025
zackpollard
added a commit
that referenced
this pull request
Mar 5, 2025
fix: storage template breaks when files are re-uploaded after a move failure
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When files had failed to move previously, and were then re-uploaded (or two files had the same path) the storage template system would get itself into a situation where the file could never be moved. This resolves that by cleaning up the move history table when an asset is deleted, and also does a bulk cleanup when the job is run manually.
Fixes #16354