Skip to content

fix(mobile): do not pause audio on app start #16596

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
alextran1502 merged 1 commit into from
Mar 4, 2025
Merged

fix(mobile): do not pause audio on app start #16596

alextran1502 merged 1 commit into from
Mar 4, 2025

Conversation

@shenlong-tanwen
Copy link
Member

@shenlong-tanwen shenlong-tanwen commented Mar 4, 2025

Fixes #14766

Description

  • Moves the activating Audio session logic to the native video player so it is not triggered on app startup, but rather, deferred to when a video is actually played

@alextran1502
Copy link
Member

alextran1502 commented Mar 4, 2025

Thanks! Tested it, and it works

@alextran1502 alextran1502 merged commit 3b0af1c into main Mar 4, 2025
49 checks passed
@alextran1502 alextran1502 deleted the fix/ios-silent branch March 4, 2025 22:00
zackpollard pushed a commit that referenced this pull request Mar 5, 2025
@shenlong-tanwen @zackpollard
fix(mobile): do not pause audio on app start (#16596)
11bc94a 
Co-authored-by: shenlong-tanwen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mertalev mertalev mertalev approved these changes

@alextran1502 alextran1502 Awaiting requested review from alextran1502

Assignees

No one assigned

Labels

changelog:bugfix 📱mobile

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Opening Immich on iOS Pauses Currently Playing Media

4 participants

@shenlong-tanwen @alextran1502 @mertalev