chore(mobile): fix store.put type def #16517
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zackpollard
approved these changes
Mar 3, 2025
knechtandreas
added a commit
to knechtandreas/immich
that referenced
this pull request
Mar 4, 2025
…n-grid * main: (32 commits) docs: clean up environment variables formatting & grammar (immich-app#16555) fix: reset/regenerate memories (immich-app#16548) fix(deps): update machine-learning (immich-app#16560) chore(deps): update node (immich-app#16538) refactor: migration tag repository to kysely (immich-app#16398) feat: qr code for new shared link (immich-app#16543) chore(deps): update github-actions (immich-app#16539) fix(docs): info on preloading ML models (immich-app#16452) docs: better facial recognition cluster guide (immich-app#14911) fix(web): delete action closes asset viewer in asset view (immich-app#15469) feat(cli): watch paths for auto uploading daemon (immich-app#14923) ci: weblate checks should always run, should skip on en.json (immich-app#16544) feat(web): Video memories on web (immich-app#16500) fix(deps): update typescript-projects (immich-app#16540) chore(mobile): fix store.put type def (immich-app#16517) refactor(mobile): move timeline methods to timeline repo (immich-app#16526) chore(deps): update dependency eslint-plugin-svelte to v3 (immich-app#16532) refactor(server): link live photos as part of metadata extraction instead of queueing job (immich-app#16390) chore(deps): update dependency globals to v16 (immich-app#16534) ci: don't check weblate lock on chore/translations and add success job (immich-app#16533) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The type definition for
Store.putwas incorrect leading to examples like the following getting ignored by the compilerThe change fixes it and strictly enforces the type during compile time