Skip to content

Conversation

@mertalev
Copy link
Member

Description

After the Kysely migration, assets were no longer stacked in the getDuplicates response, leading to errors in some cases when using the deduplication utility.

However, even before this, stacks were not handled by duplicate detection in the server or by the deduplication logic in the client:

  • Users who perform the "stack" action on a set of duplicates would see those assets once again marked as duplicates of each other after running duplicate detection
  • A stack where the primary asset was not marked duplicate but some of its members were would not show up in the utility
  • A duplicate group where all assets were part of the same stack would show up as one asset
  • Deduplicating only trashed the primary asset and not others (which, combined with the above, are the likely reasons behind straggling "1 asset" duplicate groups for so many people)
  • I'm not sure how the utility behaves when stacking already stacked assets

Pending more robust stack handling in this area, this PR skips assets part of a stack to align with the implementation assumptions.

Fixes #15735
Fixes #15868
Fixes #16359

@alextran1502 alextran1502 merged commit a708649 into main Feb 27, 2025
39 checks passed
@alextran1502 alextran1502 deleted the fix/server-dupe-stacked-assets branch February 27, 2025 16:16
ExceptionsOccur pushed a commit to ExceptionsOccur/immich that referenced this pull request Feb 28, 2025
…6380)

* skip stacked assets in duplicate detection

* update sql

* handle stacking after duplicate detection runs
@wwhite59
Copy link

Issue #16359 still persists after upgrading to 1.130.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

5 participants