fix(web): thumbnail playback stops when hovering over icon then video #16302
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NicholasFlamy
commented
Feb 24, 2025
| curve={selected} | ||
| durationInSeconds={timeToSeconds(asset.duration)} | ||
| playbackOnIconHover | ||
| playbackOnIconHover={!$playVideoThumbnailOnHover} |
Collaborator
Author
There was a problem hiding this comment.
This seemed like the simplest way to accomplish this. I disable playbackOnIconHover when the "Play video thumbnail on hover" toggle is enabled, so that playbackOnIconHover doesn't interfere.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
With the "Play video thumbnail on hover" toggle enabled, videos play when you hover over them. When you hover over the play icon, it re-enables playback. Then, when you move off of the icon onto the rest of the video, it stops.
My proposed solution does not alter the behavior when the "Play video thumbnail on hover" toggle is disabled.
How Has This Been Tested?
Videos
Old Behavior:
Screen.Recording.2025-02-09.211435.mp4
New Behavior:
Screen.Recording.2025-02-09.211518.mp4
Checklist:
src/servicesuses repositories implementations for database calls, filesystem operations, etc.src/repositories/is pretty basic/simple and does not have any immich specific logic (that belongs insrc/services)