Skip to content

Conversation

@Snowknight26
Copy link
Collaborator

@Snowknight26 Snowknight26 commented Feb 10, 2025

Description

The capitalization of the word Exif in the Share modal now matches the capitalization in the Shared links page.

How Has This Been Tested?

  • Navigated to shared link modal in the UI

Screenshots (if appropriate)

image

Checklist:

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation if applicable
  • I have no unrelated changes in the PR.
  • I have confirmed that any new dependencies are strictly necessary.
  • I have written tests for new code (if applicable)
  • I have followed naming conventions/patterns in the surrounding code
  • All code in src/services uses repositories implementations for database calls, filesystem operations, etc.
  • All code in src/repositories/ is pretty basic/simple and does not have any immich specific logic (that belongs in src/services)

@Snowknight26
Copy link
Collaborator Author

Would write some tests to test the function change but my environment ain't liking something.

Instead change the require of index-client.js in /home/snowknight26/immich-dev/web/node_modules/svelte-local-storage-store/dist/index.js to a dynamic import() which is available in all CommonJS modules.
Error [ERR_REQUIRE_ESM]: require() of ES Module /home/snowknight26/immich-dev/web/node_modules/svelte/src/store/index-client.js from /home/snowknight26/immich-dev/web/node_modules/svelte-local-storage-store/dist/index.js not supported.
Instead change the require of index-client.js in /home/snowknight26/immich-dev/web/node_modules/svelte-local-storage-store/dist/index.js to a dynamic import() which is available in all CommonJS modules.
    at TracingChannel.traceSync (node:diagnostics_channel:315:14)
    at /home/snowknight26/immich-dev/web/node_modules/svelte-local-storage-store/dist/index.js:27:20
    at VitestExecutor.runModule (file:///home/snowknight26/immich-dev/web/node_modules/vite-node/dist/client.mjs:399:11)
    at VitestExecutor.runModule (file:///home/snowknight26/immich-dev/web/node_modules/vitest/dist/chunks/execute.4vt3NSmG.js:776:20)

@jrasm91 jrasm91 merged commit b40963e into immich-app:main Feb 11, 2025
35 of 36 checks passed
@Snowknight26 Snowknight26 deleted the update-shared-link branch March 2, 2025 23:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants