feat: persistent memories #15953
feat: persistent memories #15953
Conversation
jrasm91
commented
Feb 7, 2025
jrasm91
commented
- Generate "on this day" memories in the background
- Add the option to "favorite" memories, which prevents them from being deleted
- Add the option to delete a memory
- Add the option to remove an asset from a memory
etnoy
left a comment
etnoy
left a comment
There was a problem hiding this comment.
This is great, I've been hoping for this
jrasm91
force-pushed
the
feat/memories
branch
3 times, most recently
from
14792c4 to
5793bba
Compare
refactor chore: use heart as favorite icon fix: linting
jrasm91
force-pushed
the
feat/memories
branch
from
5793bba to
0f98625
Compare
| export type SystemFlags = { mountChecks: Record<StorageFolder, boolean> }; | ||
| export type MemoriesState = { | ||
| /** memories have already been created through this date */ | ||
| lastOnThisDayDate: string; |
There was a problem hiding this comment.
Matching the comment above something like generatedUntilDate sounds more intuitive to me. Idk, probably personal preference
| const userMap: Record<string, string[]> = {}; | ||
| for (const user of users) { | ||
| const partnerIds = await getMyPartnerIds({ | ||
| userId: user.id, | ||
| repository: this.partnerRepository, | ||
| timelineEnabled: true, | ||
| }); | ||
| userMap[user.id] = [user.id, ...partnerIds]; | ||
| } |
There was a problem hiding this comment.
AFAICT you aren't using the features of a record here at all. You could just users.map(async ({id}) => [id, ...await getMyPartnerIds(...)])
| // generate a memory +/- X days from today | ||
| for (let i = 0; i <= DAYS * 2 + 1; i++) { | ||
| const target = start.plus({ days: i }); |
There was a problem hiding this comment.
When you say ± you don't actually just want to do start.plus always, right? Isn't what you actually want for (let i = -DAYS; i <= DAYS + 1; i++)? Or am I misunderstanding something here?
There was a problem hiding this comment.
3 days before and after today is 7 days total
There was a problem hiding this comment.
Yes I know. But you're always doing start.plus, so you basically end up at a date in 6 days, no? Also, my primary aspect was just that going from -3 to +3 is much more intuitive/better readable imo
There was a problem hiding this comment.
It doesn't start with today
