fix(web): prevent accidental modal closures on mouseup outside #15900
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ing mousedown instead of click events.
alextran1502
approved these changes
Feb 4, 2025
Member
alextran1502
left a comment
alextran1502
left a comment
There was a problem hiding this comment.
Thank you, I've been wanting to do a full sweep of this behavior across all forms components on the web
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Many times I close modals by accident when selecting text, because the listener is click (does not matter when the mousedown began, only where the mouseup ends), for example:
2025-02-04_immich_modal_close.mp4
This is a suggested fix.