feat(server): Nullable asset dates #15669
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
etnoy
force-pushed
the
feat/nullable-dates
branch
3 times, most recently
from
f5f4059 to
52ba6fa
Compare
etnoy
force-pushed
the
feat/nullable-dates
branch
4 times, most recently
from
bc9702a to
50de167
Compare
etnoy
force-pushed
the
feat/nullable-dates
branch
2 times, most recently
from
3a1c659 to
3723484
Compare
github-actions
bot
added
documentation
etnoy
force-pushed
the
feat/nullable-dates
branch
from
3723484 to
fd823d2
Compare
etnoy
force-pushed
the
feat/nullable-dates
branch
from
fd823d2 to
3b4276f
Compare
etnoy
force-pushed
the
feat/nullable-dates
branch
6 times, most recently
from
71fc410 to
e213a74
Compare
etnoy
force-pushed
the
feat/nullable-dates
branch
3 times, most recently
from
053b814 to
52d2206
Compare
etnoy
force-pushed
the
feat/nullable-dates
branch
from
52d2206 to
0222ef6
Compare
etnoy
force-pushed
the
feat/nullable-dates
branch
11 times, most recently
from
7034792 to
32dc64f
Compare
etnoy
force-pushed
the
feat/nullable-dates
branch
4 times, most recently
from
3843642 to
a9ce302
Compare
etnoy
force-pushed
the
feat/nullable-dates
branch
from
a9ce302 to
c3c6ba6
Compare
danieldietzler
approved these changes
Feb 7, 2025
Comment on lines
+165
to
+171
| if (!asset.fileCreatedAt) { | ||
| asset.fileCreatedAt = stats.mtime; | ||
| } | ||
|
|
||
| if (!asset.fileModifiedAt) { | ||
| asset.fileModifiedAt = stats.mtime; | ||
| } |
Collaborator
Author
There was a problem hiding this comment.
External assets :)
Since they are imported by the library service with null dates, this is where they become non-null.
mertalev
approved these changes
Feb 13, 2025
Member
mertalev
left a comment
mertalev
left a comment
There was a problem hiding this comment.
LGTM, I don't see anything problematic with this change
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow fileCreatedAt, fileModifiedAt, localDateTime to be null, making them placeholders before metadata extraction runs
No dtos have changed, so clients don't need to be updated