fix(web): end selection after click when choosing thumbnail, and notify #15373
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes immich-app#14692 viewMode state was being changed before updateThumbnail which caused AssetGrid.handleSelectAssets() to continue, instead of returning. Also added notification to notify user that the album cover was updated.
alextran1502
approved these changes
Jan 15, 2025
alextran1502
changed the title
Member
|
Thanks! |
vladd11
pushed a commit
to vladd11/immich
that referenced
this pull request
Jan 25, 2025
…fy (immich-app#15373) fix(web): Change viewMode state after updateThumbnail Fixes immich-app#14692 viewMode state was being changed before updateThumbnail which caused AssetGrid.handleSelectAssets() to continue, instead of returning. Also added notification to notify user that the album cover was updated.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
viewModestate was being changed beforeupdateThumbnail()which causedhandleSelectAssets()to continue, instead of returning.My solution was to move the
updateThumbnail()API call before changing theviewModestate.I also added notification to notify user that the album cover was
updated.
Fixes #14692