fix(cli): handle folders with single quotes #15283
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Good catch. We recently made a similar fix in the library service scanner but also added other problematic characters. Perhaps the same fix could be done here? |
Collaborator
See https://github.com/immich-app/immich/pull/14856/files |
alextran1502
approved these changes
Jan 12, 2025
yosit
pushed a commit
to yosit/immich
that referenced
this pull request
Jan 13, 2025
* fix(cli): handle folders with single quotes * fix(cli): skip single quote test on Windows * fix(cli): support double quote and backtick as well
arctic-foxtato
pushed a commit
to arctic-foxtato/immich
that referenced
this pull request
Jan 14, 2025
* fix(cli): handle folders with single quotes * fix(cli): skip single quote test on Windows * fix(cli): support double quote and backtick as well
vladd11
pushed a commit
to vladd11/immich
that referenced
this pull request
Jan 25, 2025
* fix(cli): handle folders with single quotes * fix(cli): skip single quote test on Windows * fix(cli): support double quote and backtick as well
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #12076.
CLI handling of single quotes needs special handling, similar to #14856.