fix(mobile): 15072 Fix issue with boolean filters filtering out results when they shouldn't #15208
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aminesebastian
pushed a commit
to suburban-digital/immich-sd
that referenced
this pull request
Jan 12, 2025
…ts when they shouldn't (immich-app#15208) Fix issue with boolean filters filtering out results when they shouldn't. Co-authored-by: Tom graham <[email protected]>
yosit
pushed a commit
to yosit/immich
that referenced
this pull request
Jan 13, 2025
…ts when they shouldn't (immich-app#15208) Fix issue with boolean filters filtering out results when they shouldn't. Co-authored-by: Tom graham <[email protected]>
arctic-foxtato
pushed a commit
to arctic-foxtato/immich
that referenced
this pull request
Jan 14, 2025
…ts when they shouldn't (immich-app#15208) Fix issue with boolean filters filtering out results when they shouldn't. Co-authored-by: Tom graham <[email protected]>
vladd11
pushed a commit
to vladd11/immich
that referenced
this pull request
Jan 25, 2025
…ts when they shouldn't (immich-app#15208) Fix issue with boolean filters filtering out results when they shouldn't. Co-authored-by: Tom graham <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #15072
The
isArchived,isFavouriteandisNotInAlbumfilters were getting passed in the search asfalsewhen not ticked; they should be getting passed asnullin this case (since we don't support exclusion).Validated that results matching these cases are now correctly returned when these filters are unchecked.