Skip to content

Conversation

@arnolicious
Copy link
Collaborator

@arnolicious arnolicious commented Jan 2, 2025

So I don't know if this was intentionally omitted, or just wasn't implemented yet.

I hope it's the latter, since I would find this very useful, aswell as a few other people in #14307

I haven't been able to test it completely, since I'm on windows and my bind mounts seem to be a lil fucked up, resulting in folders with only one image in it, so some other testers would be greatly appreciated.

If this was indeed intentionally omitted, feel free to close the PR

Edit

I also added a button in the Asset View Detail Pane that links to the containing folder. That way, when you open an asset from the timeline or search, you can jump straight into the folder view to the correct folder.

This button only shows up, if folders are enabled and the Folder sidebar link is also activated.

Closes #14307

const triggerAssetUpdate = () => {};
const onAddToAlbum = (assetIds: string[]) => {
// if (terms.isNotInAlbum.toString() == 'true') {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we handle this case as well?

};
const onAssetDelete = (assetIds: string[]) => {
// const assetIdSet = new Set(assetIds);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we handle this case as well?

@arnolicious
Copy link
Collaborator Author

I implemented the refreshing of assets @alextran1502

I also added a button in the Asset View Detail Pane that links to the containing folder. That way, when you open an asset from the timeline or search, you can jump straight into the folder view to the correct folder.

This button only shows up, if folders are enabled and the Folder sidebar link is also activated.

@alextran1502
Copy link
Member

Hi @arnolicious, I just tested the PR, and it works well.

For navigating to the folder from the detail panel, can we make this link clickable instead?

image

mdiClose,
mdiEye,
mdiEyeOff,
mdiFolder,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove the unused code so the tests pass, thank you

@alextran1502 alextran1502 enabled auto-merge (squash) January 3, 2025 15:54
@alextran1502 alextran1502 merged commit b45ff8d into immich-app:main Jan 3, 2025
33 checks passed
yosit pushed a commit to yosit/immich that referenced this pull request Jan 13, 2025
…5049)

* feat(web): Enable selection interactions in folder view

* feat(web): Add link to parent folder in detail pane, if folders are enabled

* Added invalidation and refreshing of asset cache on changes

* fix: removed unused imports and changed link

* chore: styling

---------

Co-authored-by: Alex Tran <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants