[API] tagAssets doesn't tag all assets randomly

[simulot]

I have searched the existing issues, both open and closed, to make sure this is not a duplicate report.

• Yes

The bug

The API call tagAssets often tags not all assets given in the call.

The OS that Immich Server is running on

Ubuntu

Version of Immich Server

v1.129.0

Version of Immich Mobile App

N/A

Platform with the issue

• Server
• Web
• Mobile

Your docker-compose.yml content

Not relevant

Your .env content

Not relevant

Reproduction steps

I writing test cases for Immich-go, that wipes out the immich's tables, and upload a handful of images, with tag and album.

May be 1 over 3 test3, immich misses to tag an asset.
The API call return show a success for all tagged assets

Relevant log output

immich_server  | �[95m[Nest] 17  - �[39m03/09/2025, 1:17:28 PM �[95m  DEBUG�[39m �[33m[Api:LoggingInterceptor~9bcb8x7p]�[39m �[95mPUT /api/tags/bececdd5-bb46-4201-8551-a0300809c12c/assets 200 27.63ms ::ffff:172.18.0.1�[39m
immich_server  | �[96m[Nest] 17  - �[39m03/09/2025, 1:17:28 PM �[96mVERBOSE�[39m �[33m[Api:LoggingInterceptor~9bcb8x7p]�[39m �[96m{"ids":["44891c00-8964-4882-a921-70c781d4a89a","bdfe3e04-9c24-4ada-8bac-69952f38a283","19182cda-f568-4c74-ade4-7b3a53a2a602","c9f9e3ce-3054-480b-85eb-f718e21401ea","807af51b-e29f-4db0-951c-904c57e8441d"]}�[39m

Additional information

Immich-go api trace:

025-03-09T14:17:28+01:00 QUERY 13 UpsertTags PUT http://localhost:2283/api/tags
   Content-Type [application/json]
   Accept [application/json]
   X-Api-Key redacted
-- body start --
{"tags":["tag/subtag"]}
-- body end --

2025-03-09T14:17:28+01:00 RESPONSE 13 UpsertTags PUT http://localhost:2283/api/tags
  Header:
     Date : Sun, 09 Mar 2025 13:17:28 GMT
     Connection : keep-alive
     Keep-Alive : timeout=5
     X-Powered-By : Express
     X-Immich-Cid : rtoee2rp
     Content-Type : application/json; charset=utf-8
     Content-Length : 212
     Etag : "d4-WX1a0e5OR3gUbCjRKZNhnbYtz24"
  Status: 200 OK
-- response body start --
[{"id":"bececdd5-bb46-4201-8551-a0300809c12c","parentId":"a4af078e-4993-4aef-b774-49dd3ee08cc2","name":"subtag","value":"tag/subtag","createdAt":"2025-03-09T13:17:28.192Z","updatedAt":"2025-03-09T13:17:28.192Z"}]
-- response body end --

2025-03-09T14:17:28+01:00 QUERY 14 TagAssets PUT http://localhost:2283/api/tags/bececdd5-bb46-4201-8551-a0300809c12c/assets
   X-Api-Key redacted
   Content-Type [application/json]
   Accept [application/json]
-- body start --
{"ids":["44891c00-8964-4882-a921-70c781d4a89a","bdfe3e04-9c24-4ada-8bac-69952f38a283","19182cda-f568-4c74-ade4-7b3a53a2a602","c9f9e3ce-3054-480b-85eb-f718e21401ea","807af51b-e29f-4db0-951c-904c57e8441d"]}
-- body end --

2025-03-09T14:17:28+01:00 RESPONSE 14 TagAssets PUT http://localhost:2283/api/tags/bececdd5-bb46-4201-8551-a0300809c12c/assets
  Header:
     Keep-Alive : timeout=5
     X-Powered-By : Express
     X-Immich-Cid : 9bcb8x7p
     Content-Type : application/json; charset=utf-8
     Content-Length : 306
     Etag : "132-Nm/wGpjeBvL9J1m/yBxBNA+kiHY"
     Date : Sun, 09 Mar 2025 13:17:28 GMT
     Connection : keep-alive
  Status: 200 OK
-- response body start --
[{"id":"44891c00-8964-4882-a921-70c781d4a89a","success":true},{"id":"bdfe3e04-9c24-4ada-8bac-69952f38a283","success":true},{"id":"19182cda-f568-4c74-ade4-7b3a53a2a602","success":true},{"id":"c9f9e3ce-3054-480b-85eb-f718e21401ea","success":true},{"id":"807af51b-e29f-4db0-951c-904c57e8441d","success":true}]
-- response body end --

The table tag_asset content:

"assetsId"	"tagsId"
"807af51b-e29f-4db0-951c-904c57e8441d"	"bececdd5-bb46-4201-8551-a0300809c12c"
"44891c00-8964-4882-a921-70c781d4a89a"	"bececdd5-bb46-4201-8551-a0300809c12c"
"bdfe3e04-9c24-4ada-8bac-69952f38a283"	"bececdd5-bb46-4201-8551-a0300809c12c"
"c9f9e3ce-3054-480b-85eb-f718e21401ea"	"bececdd5-bb46-4201-8551-a0300809c12c"

full logs attached

log.log

immich-go_2025-03-09_14-17-27.trace.log

[danieldietzler]

To clarify; this is a race condition between metadata extraction and updating tags. Uploading multiple images and immediately updating the tags will cause this.

[simulot]

I did few tests:

• when the tag is missing in the UI, the XMP file isn't generated
• the probability of appearance increase with the number of files present in the library