Shared by link images without metadata does not load

[holas1337]

The bug

If I choose images, share by link disabling metadata the images does not load using the link.
When I enable metadata it works.

Here is an example in your demo
https://demo.immich.app/sharing/sharedlinks
https://demo.immich.app/share/tsS8_nVLxcmfbwA-_pVZYcddxgx3iSFwNcG8Hz_pfnsWRNFSES1IGPj5eCdfBvZEnsU

The OS that Immich Server is running on

--

Version of Immich Server

v1.125.7

Version of Immich Mobile App

--

Platform with the issue

• Server
• Web
• Mobile

Your docker-compose.yml content

--

Your .env content

--

Reproduction steps

Choose some photos, share by link and set it like this

Then when visiting the link it will look like this

and the images will never load.

Relevant log output

Additional information

No response

[bo0tzz]

It works just fine for me. What browser are you using? Does this still happen in an incognito tab, with all extensions disabled, cache cleared, etc?

[Mraedis]

It works just fine for me. What browser are you using? Does this still happen in an incognito tab, with all extensions disabled, cache cleared, etc?

Same behaviour for me, both FF and Edge, incognito or not, extensions disabled or not, logged in or not.

I can see 2 images being loaded, 1 is the logo which shows and 1 is a 1x1 pixel white square.

[Mraedis]

I made a new link https://demo.immich.app/share/KJzspp3k_NJQd7CturA88ulk-BrypvNvIsZvqJNDygfMpei70gblZDYLz6CUHuRyMlU and I can only see images if I go through the sharedlinks selection, not if I go directly to the link. If I refresh the page with images then they also disappear.

Turning on metadata fixes it.
Turning it off again breaks it again.

[bo0tzz]

Browser console logs:

XHRGET
https://demo.immich.app/api/users/me
[HTTP/3 401  12ms]

XHRGET
https://demo.immich.app/api/users/me/preferences
[HTTP/3 401  12ms]

XHRGET
https://demo.immich.app/api/server/about
[HTTP/3 401  10ms]

Uncaught DOMException: String contains an invalid character
    Immutable 51
[C2PPtOS8.js:1](https://demo.immich.app/_app/immutable/chunks/C2PPtOS8.js)
Uncaught (in promise) DOMException: String contains an invalid character
    Immutable 18
        we
        Z
        rt
        a
        z
        T
        an
        ot
        Wn
        un
        fn
        E
        <anonymous>
        xt
        K
        Ee
        Nn
        Wn
    async* KJzspp3k_NJQd7CturA88ulk-BrypvNvIsZvqJNDygfMpei70gblZDYLz6CUHuRyMlU:205
    promise callback* KJzspp3k_NJQd7CturA88ulk-BrypvNvIsZvqJNDygfMpei70gblZDYLz6CUHuRyMlU:204

This seems to be happening in the thumbhash handling code. Looking at the network requests, I see:
thumbhash: "\\x30080a038077f8888877e78851a7707707"
Which I believe is being serialized incorrectly.

[bo0tzz]

I think I've found the culprit. Since the kysely migration, there's a new check for serializing hash values:

immich/server/src/dtos/asset-response.dto.ts

Line 141 in fe42e74

thumbhash: entity.thumbhash ? hexOrBufferToBase64(entity.thumbhash) : null,

However, this seems to have been missed for the case where metadata is being stripped for a shared link:

immich/server/src/dtos/asset-response.dto.ts

Line 121 in fe42e74

thumbhash: entity.thumbhash?.toString('base64') ?? null,