Add alpha premultiplication to tiff based on ExtraSamples tag#2889
Closed
mpospelova wants to merge 2 commits intoimage-rs:mainfrom
Closed
Add alpha premultiplication to tiff based on ExtraSamples tag#2889mpospelova wants to merge 2 commits intoimage-rs:mainfrom
mpospelova wants to merge 2 commits intoimage-rs:mainfrom
Conversation
Member
|
Our |
Member
|
@mpospelova Of course it means our decoder is wrong in all the other cases right now. If you want to contribute a PR, I'd gladly see one fixing color fidelity in that direction by checking the tag. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
libtiff premultiplies the alpha channel based on the ExtraSamples tag (Tag 338). This pull request mimics the behavior of libtiff.
For value 0 (unspecified), libtiff does not perform any premultiplication and this PR sets the premultiplication flag to false
For value 1 (associated alpha), the rgb channels are already premultiplied and libtiff doesn't do anything. This PR sets the premultiplication flag to false in this case
For value 2 (unassociated alpha), libtiff multiplies the color channels by the alpha value. This PR mimics this by performing premultiplication with the pic-scale-safe library