Xorg formats Decoders do not accept valid files with spurious errors

[amyspark]

Hi,

The following files cannot be decoded with image-extras:

• abydos.xbm.zip

• abydos.xpm.zip

The XBM file fails parsing with the following (looks like the decoder doesn't accept the canonical header, but the line/col value is fixed so cannot tell for sure):

0:00:00.613199800       9392      19012 WARN         ImageRsTypeFind video\image\src\typefind\xbm.rs:25:gstimagers::typefind::xbm::type_find::{{closure}}: File is not X Bitmap: Format error decoding `XBM`: Failed to parse #define for image width, unexpected character or eof at byte=1,line=1:col=1

The XPM file fails parsing with the well-known (#40)

0:00:00.436574500      11584      14148 ERROR             imagersdec video\image\src\decoder\imp.rs:286:gstimagers::decoder::imp::Decoder::render_single_frame::{{closure}}:<imagersdecoder0> Failed decoding single image: The image format could not be determined

[mstoeckl]

looks like the decoder doesn't accept the canonical header,

This is not a standard header; more generally the XBM format description (https://www.x.org/releases/X11R7.7/doc/libX11/libX11/libX11.html#Manipulating_Bitmaps ) does not mention that comments are expected. That being said, I've seen a few old XBM-like images which have license text, random comments, in them, so it may be worth making the decoder much more relaxed (to either accept comments, or (to match libx11) entirely ignore lines it does not recognize).

abydos.xpm decodes fine for me when using the convert example program from image-extras.

[amyspark]

abydos.xpm decodes fine for me when using the convert example program from image-extras.

Can confirm this, manually instantiating XPM (not going through the signature hooks etc. from ImageReader) succeeds and yields the image.