Skip to content

Adjust .ssp.transport to avoid negative emissions totals #389

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Aug 5, 2025
Merged

Conversation

khaeru
Copy link
Member

@khaeru khaeru commented Jul 30, 2025

Closes #387.

The initial commits implement the first method described at that issue, from the description of #387. These were made before the method was changed again; the later commits [will] implement the second method.

How to review

  • Read the diff.
  • Note that the CI checks all pass.

PR checklist

  • Continuous integration checks all ✅
  • Add or expand tests; coverage checks both ✅
  • Add, expand, or update documentation.
  • Update doc/whatsnew.

@khaeru khaeru added this to the 2025-08 milestone Jul 30, 2025
@khaeru khaeru self-assigned this Jul 30, 2025
@khaeru khaeru added enh New features or functionality report genno-based reporting and post-solve processing transport MESSAGEix-Transport variant or transport in the base model p:SSP-2024 2024 SSP updates and ScenarioMIP labels Jul 30, 2025
@khaeru khaeru changed the title Adjust .ssp.transport to adjust negative emissions totals Adjust .ssp.transport to avoid negative emissions totals Jul 30, 2025
Copy link

codecov bot commented Jul 30, 2025

Codecov Report

❌ Patch coverage is 89.06250% with 7 lines in your changes missing coverage. Please review.
✅ Project coverage is 76.2%. Comparing base (945afcb) to head (0335c1f).
⚠️ Report is 10 commits behind head on main.

Files with missing lines Patch % Lines
message_ix_models/project/ssp/transport.py 85.7% 6 Missing ⚠️
...sage_ix_models/tests/project/ssp/test_transport.py 95.2% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##            main    #389     +/-   ##
=======================================
- Coverage   76.9%   76.2%   -0.8%     
=======================================
  Files        246     246             
  Lines      19866   19897     +31     
=======================================
- Hits       15279   15162    -117     
- Misses      4587    4735    +148     
Files with missing lines Coverage Δ
...age_ix_models/tests/model/transport/test_report.py 94.1% <100.0%> (+<0.1%) ⬆️
...sage_ix_models/tests/project/ssp/test_transport.py 99.1% <95.2%> (-0.9%) ⬇️
message_ix_models/project/ssp/transport.py 97.0% <85.7%> (+0.7%) ⬆️

... and 7 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

khaeru added 2 commits August 1, 2025 13:49
Skip this test on macOS and Windows GHA runners (flaky; times out).
khaeru added a commit that referenced this pull request Aug 5, 2025
khaeru added a commit that referenced this pull request Aug 5, 2025
khaeru added a commit that referenced this pull request Aug 5, 2025
khaeru added a commit that referenced this pull request Aug 5, 2025
@khaeru khaeru marked this pull request as ready for review August 5, 2025 10:03
@khaeru khaeru requested a review from r-aneeque as a code owner August 5, 2025 10:03
@khaeru khaeru merged commit d96b840 into main Aug 5, 2025
45 of 46 checks passed
@khaeru khaeru deleted the issue/387 branch August 5, 2025 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enh New features or functionality p:SSP-2024 2024 SSP updates and ScenarioMIP report genno-based reporting and post-solve processing transport MESSAGEix-Transport variant or transport in the base model
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Expand .ssp.transport to track changes in implied GAINS emissions factors
1 participant