Skip to content

Conversation

@guusdk
Copy link
Member

@guusdk guusdk commented Oct 13, 2025

Geolocation, Mood and UserTune functionality depends on the availability of PEP. If the server doesn't support PEP functinality, these tests should throw a TestNotPossible exception.

Geolocation, Mood and UserTune functionality depends on the availability of PEP. If the server doesn't support PEP functinality, these tests should throw a TestNotPossible exception.
@guusdk guusdk requested a review from Flowdalic October 13, 2025 13:09
@Neustradamus
Copy link

@guusdk: Thanks for your work on the PEP test :)
It is on the road to fix PEP (OMEMO included too).

@Flowdalic
Copy link
Member

This approach duplicates code. How about adding

void ensurePepSupported(XMPPConnection connection) throws …

to AbstractSmackIntegrationTest and calling this method in the constructor of the related tests.

@guusdk
Copy link
Member Author

guusdk commented Nov 12, 2025

I see your point, but I am not convinced this change adds much value. The number of tests affected is small, and the duplication avoided is minimal. We would just be wrapping the same PepManager.getInstanceFor(conOne).isSupported() call.

Adding isSupported() to GeoLocationManager, MoodManager, and UserTuneManager would be more consistent with MamManager and OmemoManager, but that feels like overkill for such an old and rarely used mechanism.

I would lean toward keeping it simple.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants