feat(meetings): Use "Decline and Delete" for slide disapprovals#9842
Merged
rjsparks merged 2 commits intoietf-tools:mainfrom Nov 3, 2025
Merged
feat(meetings): Use "Decline and Delete" for slide disapprovals#9842rjsparks merged 2 commits intoietf-tools:mainfrom
rjsparks merged 2 commits intoietf-tools:mainfrom
Conversation
Changes use of "disapprove" and "rejected" to "decline" and "declined" when dealing with slides that have been submitted for approval. Responds to ietf-tools#9242
Now with a fix for a test that broke owing to the original change. Still responds to ietf-tools#9242
Spectre17
changed the title
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #9842 +/- ##
==========================================
- Coverage 88.54% 88.54% -0.01%
==========================================
Files 316 316
Lines 42265 42265
==========================================
- Hits 37423 37422 -1
- Misses 4842 4843 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
rjsparks
approved these changes
Nov 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes use of "disapprove" and "rejected" to "decline" and "declined" when dealing with slides that have been submitted for approval. This PR also fixes a test failure in the previous PR #9840.